Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the location type returned in GridPatch when padding #4598

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Fix the location type returned in GridPatch when padding #4598

merged 4 commits into from
Jun 29, 2022

Conversation

vale-salvatelli
Copy link
Contributor

Fixes #4597 .

Description

The location type returned in GridPatch when padding should be List to be consistent with the locations returned when not padding

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli
wyli approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reporting and fixing this, could you please sign the commit https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work then I'll merge the PR.

@vale-salvatelli
Copy link
Contributor Author

vale-salvatelli commented Jun 29, 2022 •
edited
Loading

Sorry for the slow answer. I signed my last commit - hope it's OK now @wyli

@wyli
Copy link
Contributor

wyli commented Jun 29, 2022

Sorry for the slow answer. I signed my last commit - hope it's OK now @wyli

thanks! I'll merge this one soon.

@wyli wyli enabled auto-merge (squash) June 29, 2022 09:58
@wyli
Copy link
Contributor

wyli commented Jun 29, 2022

/build

@wyli wyli merged commit 112d36c into Project-MONAI:dev Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GridPatch returns inconsistent type location when padding
2 participants
@vale-salvatelli @wyli